Adding Child Managers to EMS #15889
Merged
Adding Child Managers to EMS #15889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This PR is needed for Amazon refresh consolidation PR and * Orchestrate destroy of dependent managers. It allows us to say things like: `ems.child_managers.collect ...` which gets all the child mangers of a parent.
|
@agrare you're adding yourself and labels, quicker than I can switch tabs! |
|
@durandom is there anything else you'd need in this pr for your pr, or this bare bones ok? |
1 similar comment
|
@durandom is there anything else you'd need in this pr for your pr, or this bare bones ok? |
|
Checked commit juliancheal@961b02f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and
It allows us to say things like:
ems.child_managers.collect ...which gets all the child mangersof a parent.
This PR is needed for the following PRs
#15711 & #15590