Optimize speed and stabilize the batch graph refresh memory usage #15897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize speed and mem peaks a bit doing removing attribute_index elements as we go and building all_attribute_keys inline
Optimize serializable keys by preloading it into hash and only calling serialize for columns that actually neeed it.
Use pg_types for building serializable_keys and extract pg_types to init, so it's built only once.
Ladas
force-pushed
the
optimize_speed_stabilize_the_batch_graph_refresh_memory_usage
branch
from
383b5cf
to
7e5091f
Compare
|
Checked commits Ladas/manageiq@59c7172~...7e5091f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize speed and stabilize the batch graph refresh memory usage
The refresh speed gain on a big environment(1.2M records) is about 10% and memory rise much less after the parsing step.