Have parent inventory collections as dependencies #15903
Conversation
Add parent_inventory_collections as a dependency, to ensure we always run disconnect by parent first, even if the current collection is blank
Add __parent_inventory_collections as intenrnal attribute, so it's ignored by black/white listing
|
@Ladas 'enhancement' is an invalid assignee, ignoring... |
Add parent_inventory_collections to attributes spec
Make parent_inventory_collection mandatory only for targeted, in the full refresh, we will tolerate a missing IC, since they each persistor can have only subset of them.
|
Checked commits Ladas/manageiq@05391f9~...539beb5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Thanks for the phenomenally quick fix! |
|
@cben I think the specs should be enough in Containers and AWS? The thing here is that if we don't pass any CustomAttribute for saving, the dependency graph can't be built, so in this case the saving of CustomAttribute was done before the saving of ContainerImage. The :parent_inventory_collections serve for having fixed dependency there, so even if we have no data, the processing of ContainerImages will be done before CustomAttributes. So this is only for doing the right order of disconnects. And it aligns with how we set parent_inventory_collections for a targeted refresh. If that would not align in the future, we would add another field for modeling fixed dependencies for the right order of disconnects. |
|
Ah OK, I'm not familiar yet with how targetted refresh is normally done :-) |
Have parent inventory collections as dependencies, so we always ensure that disconnect is done via parent(dependency), even if the current collection is empty.