Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the userid is not found in the DB do a case insensitive search #15904

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

jvlcek
Copy link
Member

@jvlcek jvlcek commented Aug 29, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1486041

If the appliance administrator manually creates a user in mixed case it would not be found.

This change will do a case insensitive search for the user. To minimize unnecessary
performance degradation, it will only do the case insensitive search if the user can
not be found as presented.

Steps for Testing/QA [Optional]

  1. Configure an appliance for authentication Mode: LDAP(s)
  2. Manually configure a new user with a mixed case userid.
  3. Attempt to log in as that user but enter the username in all upper case.

@jvlcek
Copy link
Member Author

jvlcek commented Aug 29, 2017

@gtanzillo Please review. Note I also DRYed the code you suggested I might want to from my last PR :)

@miq-bot
Copy link
Member

miq-bot commented Aug 29, 2017

Checked commit jvlcek@7135b43 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 1 offense detected

app/models/authenticator/base.rb

@jvlcek
Copy link
Member Author

jvlcek commented Aug 30, 2017

@miq-bot add_labels bug

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo merged commit 63e85c8 into ManageIQ:master Sep 5, 2017
@gtanzillo gtanzillo added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 5, 2017
@jvlcek jvlcek deleted the bz1486041_mixed_case_db branch November 10, 2017 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants