Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSCAP scan to supported features mixin #15944

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

aufi
Copy link
Member

@aufi aufi commented Sep 7, 2017

OpenSCAP scan is an action similar to Smart State Analysis,
but scanning security vulnerabilities.

Adding it to SupportsFeature mixin while making it supported in
OpenStack provider.

OpenSCAP scan is an action similar to Smart State Analysis,
but scanning security vulnerabilities.

Adding it to SupportsFeature mixin while making it supported in
OpenStack provider.
@miq-bot
Copy link
Member

miq-bot commented Sep 7, 2017

Checked commit aufi@75d822c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

app/models/mixins/supports_feature_mixin.rb

  • ❗ - Line 92, Col 5 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

@durandom
Copy link
Member

@moolitayer how do you do this in containerland? Is by default everything openscap enabled? Would it make sense for you to use the support feature mixin as well?

@moolitayer
Copy link

When a user scans a ContainerImage, we always run both an OpenSCAP scan & and a package scan[1] @durandom. We don't need to make that distinction ATM.

[1] https://github.com/ManageIQ/manageiq-providers-kubernetes/blob/0a9976a0a8491a4fca88d724c163ad73fb40e9ec/spec/models/manageiq/providers/kubernetes/container_manager/scanning/job_spec.rb

@durandom
Copy link
Member

@aufi do you already have a corresponding PR in the UI and openstack?

@aufi
Copy link
Member Author

aufi commented Sep 26, 2017

@durandom Not yet, should I create a placeholder WIP PR for reference in OpenStack repo?

Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me

@miq-bot assign @agrare

@agrare please merge if you are ok with it

@durandom
Copy link
Member

@moolitayer once this is merged, you might want to add supports :open_scap to the container base models or if you are using subclasses to the subclasses

@agrare agrare added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 26, 2017
@agrare agrare merged commit 75d822c into ManageIQ:master Sep 26, 2017
agrare added a commit that referenced this pull request Sep 26, 2017
Add OpenSCAP scan to supported features mixin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants