Make tools easier to run #15957
Merged
Make tools easier to run #15957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support users running these as an executable, a ruby script, or through rails runner: ./tools/db_ping_remote.rb ruby tools/db_ping_remote.rb bin/rails r tools/db_ping_remote.rb Add executable permission Add shebang for ruby Load rails automatically for tools that require rails [skip ci] Similar to ManageIQ#14169
|
Checked commit jrafanie@7deb5ac with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Do all of these tools actually need to be run in a rails context? |
Fryguy
approved these changes
Sep 8, 2017
No, some of them, like the log_processing directoy do not require rails so I didn't add config/environment there. |
|
Looks good @jrafanie |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support users running these as an executable, a ruby script, or through
rails runner:
Add executable permission
Add shebang for ruby
Load rails automatically for tools that require rails
[skip ci]
Similar to #14169