Snapshot Support for Non-Managed Disks SSA #15960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support so that non-managed disks can be snapshotted for SSA. This change passes the snapshot value returned along for the scan call.
|
Checked commit jerryk55@36f413b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
This was referenced Sep 11, 2017
roliveri
approved these changes
Sep 12, 2017
|
@miq-bot add_label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Sep 13, 2017
Snapshot Support for Non-Managed Disks SSA (cherry picked from commit fd7db95) https://bugzilla.redhat.com/show_bug.cgi?id=1491310
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…isks Snapshot Support for Non-Managed Disks SSA (cherry picked from commit fd7db95) https://bugzilla.redhat.com/show_bug.cgi?id=1491310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support so that non-managed disks can be snapshotted
for SSA. This change passes the snapshot value returned
along for the scan call.
Two associated PRs are:
ManageIQ/manageiq-smartstate#26
and ManageIQ/manageiq-providers-azure#122
These changes are in support of a fix for https://bugzilla.redhat.com/show_bug.cgi?id=1463780
Again a decision must be made as to whether or not to back port this to Fine.
Links [Optional]
Steps for Testing/QA [Optional]
Start an Azure instance that does not have a Managed Disk. Run SSA on the instance.
@roliveri please review. Note that this and the manageiq-smartstate PR can be merged in either order.
Also note this is a one line change.