Queue destroying of linked events when instance of MiqServer destroyed #15995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
use-after_destroy-instead-of-dependent-destroy-in-miq-server
branch
from
11322a2
to
5e28dad
Compare
|
@yrudman What's the difference in time it takes to destroy the events with this change? Afaict this will still block the UI until all the events are destroyed. |
|
I wonder if it would be better to queue a deletion of all the events related to a particular object in the callback rather than actually doing the deletion there. |
yrudman
force-pushed
the
use-after_destroy-instead-of-dependent-destroy-in-miq-server
branch
from
5e28dad
to
a14d2c7
Compare
yrudman
changed the title
after_update: destroy to destroy linked events
…uld prevent UI to hang when deleting instance of MiqServer https://bugzilla.redhat.com/show_bug.cgi?id=1446585
yrudman
force-pushed
the
use-after_destroy-instead-of-dependent-destroy-in-miq-server
branch
from
a14d2c7
to
61cb1fe
Compare
yrudman
changed the title
|
@miq-bot remove-label wip |
|
Checked commits yrudman/manageiq@79ca041~...61cb1fe with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
carbonin
approved these changes
Sep 21, 2017
yrudman
deleted the
use-after_destroy-instead-of-dependent-destroy-in-miq-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queue request to destroy linked events should prevent UI to hang when deleting instance of MiqServer
https://bugzilla.redhat.com/show_bug.cgi?id=1446585
\cc @gtanzillo @carbonin
@miq-bot add-label bug, core