Use the built-in OpenShift service environment variables #16001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change we were providing the memcached and ansible service names as environment variables. These names are DNS entries that resolve to the already present values in <SVCNAME>_SERVICE_HOST. If we just use those directly, we can eliminate some template overhead. ref: https://docs.openshift.org/latest/dev_guide/environment_variables.html#automatically-added-environment-variables
carbonin
force-pushed
the
use_openshift_built_in_service_variables
branch
from
33e1ddc
to
4fe0ec4
Compare
|
Checked commit carbonin@4fe0ec4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Cool... LGTM. @bdunne Can you take a look? |
bdunne
approved these changes
Sep 20, 2017
carbonin
added a commit
to carbonin/manageiq-pods
that referenced
this pull request
Sep 20, 2017
Now that ManageIQ/manageiq#16001 is merged we can remove the environment variables that were previously being used in place of the *_SERVICE_HOST ones
|
Opened related PR in the pods repo ManageIQ/manageiq-pods#223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we were providing the memcached and ansible service names as environment variables.
These names are DNS entries that resolve to the already present values in
<SVCNAME>_SERVICE_HOST. If we just use those directly, we can eliminate some template overhead.ref: https://docs.openshift.org/latest/dev_guide/environment_variables.html#automatically-added-environment-variables
Thanks @abellotti for showing me that we could make use of these.