Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the lenovo's event_catcher time #16012

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

CharlleDaniel
Copy link
Member

This PR is able to:

  • Fix the time's lenovo event_catcher problem that was higher than heart_timeout.

Depends on: PR 83 lenovo_provider

@CharlleDaniel
Copy link
Member Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Sep 21, 2017
@miq-bot
Copy link
Member

miq-bot commented Sep 21, 2017

Checked commit CharlleDaniel@c6af949 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@CharlleDaniel
Copy link
Member Author

Morning @juliancheal and @agrare, could you review this PR, please?

Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

As a followup it would be great to move all the lenovo settings to the manageiq-providers-lenovo repository. I see log level, this (event catcher), and refresh_worker settings still in the main settings.yml

@agrare agrare added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 25, 2017
@agrare agrare merged commit c6af949 into ManageIQ:master Sep 25, 2017
agrare added a commit that referenced this pull request Sep 25, 2017
@CharlleDaniel
Copy link
Member Author

@agrare thanks for you review. About your suggestion I think that is a good idea, thank you. @rodneyhbrown7 What do you think about the idea of ​​Adam?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants