Add Tasks start page URL to shortcuts yaml file #16061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h-kataria Ready for review. |
h-kataria
reviewed
Sep 27, 2017
db/fixtures/miq_shortcuts.yml
Outdated
| @@ -484,3 +484,8 @@ | |||
| :url: /alerts_most_recent | |||
| :rbac_feature_name: monitor_alerts_most_recent | |||
| :startup: true | |||
| - :name: miq_proxy_tasks | |||
| :description: Configure / Tasks | |||
There was a problem hiding this comment.
@GregP couple of minor changes, can we change description to "Settings / Tasks" to match the features tree. Also in the url below it should be ` /miq_task/index?jobs_tab=tasks ' jobs_tab=alltasks is not a valid value.
GregP
force-pushed
the
add_tasks_to_shortcuts
branch
from
08249bc
to
97f88f0
Compare
|
@h-kataria Code refactored, ready for review. |
|
Checked commit GregP@97f88f0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
verified fix in UI. |
simaishi
pushed a commit
that referenced
this pull request
Nov 10, 2017
Add Tasks start page URL to shortcuts yaml file (cherry picked from commit c7814fb) https://bugzilla.redhat.com/show_bug.cgi?id=1497209
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Add Tasks start page URL to shortcuts yaml file (cherry picked from commit c7814fb) https://bugzilla.redhat.com/show_bug.cgi?id=1497209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This code change requires MiqShortcut.seed to run first.
Regression code change issue after extensive MIQ shortcuts Start At clean up in prior PR. Adding back Settings / Tasks start page URL to the shortcuts yaml file.
https://bugzilla.redhat.com/show_bug.cgi?id=1492155
Minimal permissions prior to code fix not working:
Logging in as Settings only user, after code fix: