Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegate name attribute to parent_manager #16067

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

durandom
Copy link
Member

when changing the name of a parent_manager, the name of the child manager is not updated.
because child_manager are mostly read-only, we just delegate the name display to the parent_manager

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1464529

@hsong-rh could you 👍 the change on the storage manager?
@moolitayer could you 👍 the change on the monitoring manager?

@miq-bot assign @agrare
@miq-bot add_label bug

@miq-bot
Copy link
Member

miq-bot commented Sep 28, 2017

Checked commit durandom@742b0d6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks fine. 🍰

@agrare
Copy link
Member

agrare commented Sep 28, 2017

👍 from me, will wait for feedback from others to merge

@durandom
Copy link
Member Author

@moolitayer here we validate the presence and uniqueness of the name. So, I'd keep setting the name there

Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hsong-rh
Copy link
Contributor

👍 from me

@agrare agrare added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 29, 2017
@agrare agrare merged commit 742b0d6 into ManageIQ:master Sep 29, 2017
agrare added a commit that referenced this pull request Sep 29, 2017
delegate name attribute to parent_manager
@durandom durandom deleted the parent_manager_delegation branch September 29, 2017 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants