-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delegate name attribute to parent_manager #16067
Conversation
eb4338b
to
742b0d6
Compare
Checked commit durandom@742b0d6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
👍 from me, will wait for feedback from others to merge |
@moolitayer here we validate the presence and uniqueness of the name. So, I'd keep setting the name there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
👍 from me |
delegate name attribute to parent_manager
when changing the name of a parent_manager, the name of the child manager is not updated.
because child_manager are mostly read-only, we just delegate the name display to the parent_manager
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1464529
@hsong-rh could you 👍 the change on the storage manager?
@moolitayer could you 👍 the change on the monitoring manager?
@miq-bot assign @agrare
@miq-bot add_label bug