Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group by docker label in chargeback for container images #16097

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

zeari
Copy link

@zeari zeari commented Oct 3, 2017

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1497663
completed by: ManageIQ/manageiq-ui-classic#2277

screencapture-localhost-3000-report-explorer-1507020536717

screencapture-localhost-3000-report-explorer-1507021199514

cc @simon3z
@miq-bot add_label chargeback, providers/containers

@miq-bot
Copy link
Member

miq-bot commented Oct 3, 2017

Checked commit zeari@c6a5f18 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 5 offenses detected

app/models/chargeback.rb

  • ⚠️ - Line 54, Col 32 - Lint/UnusedMethodArgument - Unused method argument - consumption. If it's necessary, use _ or _consumption as an argument name to indicate that it won't be used. You can also write as groupby_label_value(*) if you want the method to accept any arguments but don't care about them.
  • ⚠️ - Line 54, Col 45 - Lint/UnusedMethodArgument - Unused method argument - groupby_label. If it's necessary, use _ or _groupby_label as an argument name to indicate that it won't be used. You can also write as groupby_label_value(*) if you want the method to accept any arguments but don't care about them.
  • ❗ - Line 116, Col 26 - Style/ParenthesesAroundCondition - Don't use parentheses around the condition of an if.
  • ❗ - Line 118, Col 29 - Style/ParenthesesAroundCondition - Don't use parentheses around the condition of an elsif.

app/models/chargeback_container_image.rb

@agrare agrare added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 9, 2017
@agrare agrare merged commit c6a5f18 into ManageIQ:master Oct 9, 2017
agrare added a commit that referenced this pull request Oct 9, 2017
Group by docker label in chargeback for container images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants