Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SUI notifications product feature #16107

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented Oct 3, 2017

@miq-bot add_label enhancement
@miq-bot add_label fine/no

@chalettu
Copy link
Contributor Author

chalettu commented Oct 3, 2017

@chriskacerguis here is the PR that is needed to fulfill ManageIQ/manageiq-ui-service#1053

@miq-bot
Copy link
Member

miq-bot commented Oct 3, 2017

Checked commit chalettu@0f1d6fb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy
Copy link
Member

Fryguy commented Oct 3, 2017

Is there really a feature to get notifications? I mean, why would an admin ever turn that off? 🤔

@chriskacerguis
Copy link
Contributor

@Fryguy it's for testing. QE requested to have the feature turned off. They stated that this was something that already exists in Classic UI.

@Fryguy
Copy link
Member

Fryguy commented Oct 3, 2017

That seems like a strange reason to create a whole customer-facing "product feature"

@chriskacerguis
Copy link
Contributor

@Fryguy /shrug. We did that to match what is in Classic UI (again, per QE)

@Fryguy
Copy link
Member

Fryguy commented Oct 3, 2017

I'll merge for now for consistency with classic UI and for prior parity, but for the record I am 👎 on this feature in general cause it makes no sense from a customer-facing POV...just one more thing the user has to ignore to make it difficult for them.

@Fryguy Fryguy merged commit 8f51b23 into ManageIQ:master Oct 3, 2017
@Fryguy Fryguy added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 3, 2017
@Fryguy Fryguy self-assigned this Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants