-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable alerts definitions with datasource for Middleware Server #16125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljesusg
force-pushed
the
metrics_alerts_datasource
branch
2 times, most recently
from
October 5, 2017 11:02
2427082
to
9e523d3
Compare
aljesusg
force-pushed
the
metrics_alerts_datasource
branch
from
October 5, 2017 19:43
9e523d3
to
2f79dcf
Compare
aljesusg
force-pushed
the
metrics_alerts_datasource
branch
from
October 5, 2017 20:07
2f79dcf
to
ae583b5
Compare
@miq-bot remove_label wip |
miq-bot
changed the title
[WIP] Enable alerts definitions with datasource for Middleware Server
Enable alerts definitions with datasource for Middleware Server
Oct 5, 2017
aljesusg
force-pushed
the
metrics_alerts_datasource
branch
from
October 6, 2017 07:21
1a9ba62
to
ae583b5
Compare
Checked commits aljesusg/manageiq@ae583b5~...1a9ba62 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
8 tasks
gtanzillo
approved these changes
Oct 6, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks @gtanzillo for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need ManageIQ/manageiq-ui-classic#2309
Tasks
Let use operators <,<=,> and >=
Datasource connection create time average
Datasource connection get time average
Datasource connection max wait time
Datasource number available connections
Datasource number connections in use
Datasource number connections time out
@lucasponce Can you please take a look? I think that Get Time, Creation Time and Wait Time is based in ms, maybe we should put ( ms ).
https://issues.jboss.org/browse/HAWKULAR-1255