Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable alerts definitions with datasource for Middleware Server #16125

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

aljesusg
Copy link
Member

@aljesusg aljesusg commented Oct 5, 2017

Need ManageIQ/manageiq-ui-classic#2309

Tasks

  • DataSource - Connections Available
  • DataSource - Connections In Use
  • DataSource - Connections Timed Out
  • DataSource - Connection Get Time
  • DataSource - Connection Creation Time
  • DataSource - Connection Wait Time

screenshot from 2017-10-05 12-48-44

Let use operators <,<=,> and >=

screenshot from 2017-10-05 12-49-18

Datasource connection create time average

screenshot from 2017-10-05 12-49-42

Datasource connection get time average

screenshot from 2017-10-05 12-50-02

Datasource connection max wait time

screenshot from 2017-10-05 12-50-11

Datasource number available connections

screenshot from 2017-10-05 12-50-22

Datasource number connections in use

screenshot from 2017-10-05 12-50-32

Datasource number connections time out

screenshot from 2017-10-05 12-50-45

@lucasponce Can you please take a look? I think that Get Time, Creation Time and Wait Time is based in ms, maybe we should put ( ms ).

https://issues.jboss.org/browse/HAWKULAR-1255

@aljesusg
Copy link
Member Author

aljesusg commented Oct 5, 2017

@miq-bot add-label providers/middleware
@miq-bot add-label wip

@aljesusg
Copy link
Member Author

aljesusg commented Oct 5, 2017

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Enable alerts definitions with datasource for Middleware Server Enable alerts definitions with datasource for Middleware Server Oct 5, 2017
@miq-bot miq-bot removed the wip label Oct 5, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 6, 2017

Checked commits aljesusg/manageiq@ae583b5~...1a9ba62 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 6, 2017
@gtanzillo gtanzillo merged commit 248dce6 into ManageIQ:master Oct 6, 2017
@aljesusg
Copy link
Member Author

aljesusg commented Oct 6, 2017

Thanks @gtanzillo for merge

@aljesusg aljesusg deleted the metrics_alerts_datasource branch October 7, 2017 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants