Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When importing report symbolize keys only in 'db_options:' section #16143

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Oct 6, 2017

Issue: After importing report columns defined in include section of report were not populated.
https://bugzilla.redhat.com/show_bug.cgi?id=1498471

Report generator expect keys in include: section of report to be string.
Importing report (after #15273) change keys to symbols and include: section of report was skipped.

Fix: Symbolize keys only in db_options: section when importing report

\cc @gtanzillo

@miq-bot add-label bug, core, reporting, euwe/yes, fine/yes

BEFORE:

before

AFTER:
after

@yrudman yrudman force-pushed the simbolize-only-db-options-section-when-importing-report branch from 0963c00 to 4fca3c3 Compare October 6, 2017 19:32
@yrudman yrudman force-pushed the simbolize-only-db-options-section-when-importing-report branch from 4fca3c3 to 64250ff Compare October 7, 2017 20:10
@miq-bot
Copy link
Member

miq-bot commented Oct 7, 2017

Checked commits yrudman/manageiq@c0a6ff4~...64250ff with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@yrudman
Copy link
Contributor Author

yrudman commented Oct 8, 2017

@miq-bot assign @gtanzillo

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gtanzillo gtanzillo added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 11, 2017
@gtanzillo gtanzillo merged commit ce2d0a4 into ManageIQ:master Oct 11, 2017
@yrudman yrudman deleted the simbolize-only-db-options-section-when-importing-report branch October 11, 2017 20:24
simaishi pushed a commit that referenced this pull request Oct 23, 2017
…ion-when-importing-report

When importing report symbolize keys only in 'db_options:' section
(cherry picked from commit ce2d0a4)

https://bugzilla.redhat.com/show_bug.cgi?id=1501478
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit aa2d0e07994d2f8d7f3b01b228cb3316c75a853b
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Wed Oct 11 16:17:31 2017 -0400

    Merge pull request #16143 from yrudman/simbolize-only-db-options-section-when-importing-report
    
    When importing report symbolize keys only in 'db_options:' section
    (cherry picked from commit ce2d0a4c015138f45c82a371a75c5d77bf2a0265)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1501478

simaishi pushed a commit that referenced this pull request Nov 13, 2017
…ion-when-importing-report

When importing report symbolize keys only in 'db_options:' section
(cherry picked from commit ce2d0a4)

https://bugzilla.redhat.com/show_bug.cgi?id=1501475
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit caf0a3371aa1a99d4a3a05657e8518adb05adcfd
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Wed Oct 11 16:17:31 2017 -0400

    Merge pull request #16143 from yrudman/simbolize-only-db-options-section-when-importing-report
    
    When importing report symbolize keys only in 'db_options:' section
    (cherry picked from commit ce2d0a4c015138f45c82a371a75c5d77bf2a0265)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1501475

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…ons-section-when-importing-report

When importing report symbolize keys only in 'db_options:' section
(cherry picked from commit ce2d0a4)

https://bugzilla.redhat.com/show_bug.cgi?id=1501475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants