-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When importing report symbolize keys only in 'db_options:' section #16143
Merged
gtanzillo
merged 2 commits into
ManageIQ:master
from
yrudman:simbolize-only-db-options-section-when-importing-report
Oct 11, 2017
Merged
When importing report symbolize keys only in 'db_options:' section #16143
gtanzillo
merged 2 commits into
ManageIQ:master
from
yrudman:simbolize-only-db-options-section-when-importing-report
Oct 11, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
simbolize-only-db-options-section-when-importing-report
branch
from
October 6, 2017 19:32
0963c00
to
4fca3c3
Compare
yrudman
force-pushed
the
simbolize-only-db-options-section-when-importing-report
branch
from
October 7, 2017 20:10
4fca3c3
to
64250ff
Compare
Checked commits yrudman/manageiq@c0a6ff4~...64250ff with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
@miq-bot assign @gtanzillo |
gtanzillo
approved these changes
Oct 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
yrudman
deleted the
simbolize-only-db-options-section-when-importing-report
branch
October 11, 2017 20:24
simaishi
pushed a commit
that referenced
this pull request
Oct 23, 2017
…ion-when-importing-report When importing report symbolize keys only in 'db_options:' section (cherry picked from commit ce2d0a4) https://bugzilla.redhat.com/show_bug.cgi?id=1501478
Euwe backport details:
|
simaishi
pushed a commit
that referenced
this pull request
Nov 13, 2017
…ion-when-importing-report When importing report symbolize keys only in 'db_options:' section (cherry picked from commit ce2d0a4) https://bugzilla.redhat.com/show_bug.cgi?id=1501475
Fine backport details:
|
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…ons-section-when-importing-report When importing report symbolize keys only in 'db_options:' section (cherry picked from commit ce2d0a4) https://bugzilla.redhat.com/show_bug.cgi?id=1501475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: After importing report columns defined in include section of report were not populated.
https://bugzilla.redhat.com/show_bug.cgi?id=1498471
Report generator expect keys in
include:
section of report to be string.Importing report (after #15273) change keys to symbols and
include:
section of report was skipped.Fix: Symbolize keys only in
db_options:
section when importing report\cc @gtanzillo
@miq-bot add-label bug, core, reporting, euwe/yes, fine/yes
BEFORE:
AFTER: