Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Product Features #16164

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Fix Product Features #16164

merged 1 commit into from
Oct 10, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Oct 10, 2017

This commit broke the api specs, as it's missing a hyphen at the beginning of a new product feature

related w/ broken specs: ManageIQ/manageiq-api#116

@miq-bot add_label bug
@miq-bot assign @agrare

@abellotti
Copy link
Member

Nice hunting there @jntullo 👍

@agrare
Copy link
Member

agrare commented Oct 10, 2017

Gah I need to re-calibrate my mental yaml parser :(
Thanks for sending the fix @jntullo ! Will merge when green

@jntullo
Copy link
Author

jntullo commented Oct 10, 2017

@agrare I looked at it 50x before I realized what it was 😆

@miq-bot
Copy link
Member

miq-bot commented Oct 10, 2017

Checked commit jntullo@7b239a9 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@agrare agrare added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 10, 2017
@agrare agrare merged commit 7b239a9 into ManageIQ:master Oct 10, 2017
agrare added a commit that referenced this pull request Oct 10, 2017
@chrisarcand chrisarcand deleted the fix_product_features branch November 28, 2017 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants