Save the Lan parent_id for SCVMM #16165
Conversation
| parent_id = h.fetch_path(:parent, :id) | ||
| next if parent_id.nil? | ||
|
|
||
| switch.lans.find(h[:id]).update_attributes(:parent_id => parent_id) |
There was a problem hiding this comment.
@Ladas I'm sure you can think of a better way to do this, but I saved everything first then update the parent_id so there aren't any issues with order dependency and made the disconnects simpler. WDYT?
There was a problem hiding this comment.
Lan.where(:id => h[:id]).update_all(:parent_id => parent_id)
the query before was doing extra join and extra select, then update. This will do the same in 1 update query.
| next if h[:id].nil? | ||
|
|
||
| parent_id = h.fetch_path(:parent, :id) | ||
| next if parent_id.nil? |
There was a problem hiding this comment.
maybe a one liner?
next if (parent_id = h.fetch_path(:parent, :id)).nil?
agrare
force-pushed
the
lan_parent_child_relationship
branch
from
c25bbd3
to
e3d92f4
Compare
|
@Ladas updated, can you take another look? |
agrare
force-pushed
the
lan_parent_child_relationship
branch
from
e3d92f4
to
b68a81c
Compare
|
Checked commit agrare@b68a81c with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/models/ems_refresh/save_inventory_infra.rb
|
agrare
changed the title
Save the parent_id for a Lan for SCVMM VMNetworks