Fix Expression builder argument error by reverting #5506 #16255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… details for reporting and expression editors" This reverts commit a7597b6. Conflicts: app/models/host.rb app/models/miq_expression.rb config/locales/en.yml spec/models/miq_expression/miq_expression_spec.rb
|
Checked commits imtayadeway/manageiq@7a5dc8e~...9837f2f with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
cc @chrisarcand |
imtayadeway
changed the title
simaishi
pushed a commit
that referenced
this pull request
Nov 17, 2017
…e19a887cd85c72d1f8f08 Fix Expression builder argument error by reverting #5506 (cherry picked from commit 075ae85) https://bugzilla.redhat.com/show_bug.cgi?id=1514257
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 20, 2017
…e19a887cd85c72d1f8f08 Fix Expression builder argument error by reverting #5506 (cherry picked from commit 075ae85) https://bugzilla.redhat.com/show_bug.cgi?id=1514258
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…b9c6089ee19a887cd85c72d1f8f08 Fix Expression builder argument error by reverting ManageIQ#5506 (cherry picked from commit 075ae85) https://bugzilla.redhat.com/show_bug.cgi?id=1514258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix old bug https://bugzilla.redhat.com/show_bug.cgi?id=1236001 by reverting #5506 (the original solution) and adding
tenantsto the list of inclusion tables.I'm struggling to understand the original bug, which complained about "Tenant" not being available in Vm or Instance conditions. The solution was to add cloud tenants instead, which is the thing that breaks the bug below. As I understand it, this solution fixes both these bugs. But I'm sure there are some things I'm missing, so I'd like to discuss before proceeding.
/cc @gtanzillo @yrudman
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1491620
@miq-bot add-label bug
@miq-bot assign @gtanzillo