Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes custom button method for things with subclasses #16378

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Fixes custom button method for things with subclasses #16378

merged 1 commit into from
Nov 1, 2017

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Nov 1, 2017

Anything that's a subclass needs the base_name for custom buttons

@d-m-u
Copy link
Contributor Author

d-m-u commented Nov 1, 2017

@miq-bot assign @gmcculloug
@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2017

Checked commit d-m-u@13971bc with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@gmcculloug gmcculloug merged commit 125bf48 into ManageIQ:master Nov 1, 2017
@gmcculloug gmcculloug added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 1, 2017
@d-m-u d-m-u deleted the fixing_api_repo_that_i_just_broke branch November 1, 2017 20:11
@chessbyte chessbyte added the bug label Nov 2, 2017
simaishi pushed a commit that referenced this pull request Nov 6, 2017
@gmcculloug @simaishi
Merge pull request #16378 from d-m-u/fixing_api_repo_that_i_just_broke
54bd039 
Fixes custom button method for things with subclasses
(cherry picked from commit 125bf48)
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2017

Gaprindashvili backport details:

$ git log -1
commit 54bd03983e0d25791345a1965f304797a444d120
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed Nov 1 16:10:22 2017 -0400

    Merge pull request #16378 from d-m-u/fixing_api_repo_that_i_just_broke
    
    Fixes custom button method for things with subclasses
    (cherry picked from commit 125bf4832fe5a6b668b4ddff25c0b60a7a5c2db4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@d-m-u @miq-bot @simaishi @chessbyte @gmcculloug