Fix resize approval to work for editing requests #16381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit sseago@c3253e2 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@sseago Is there a ui-classic PR this should be linked with? |
|
@gmcculloug Oops. I mentioned it without linking in the description due to the "chicken and egg" problem with linking interdependent PRs. It didn't exist yet, but it did 2 minutes later. I'll edit the description now. |
simaishi
pushed a commit
that referenced
this pull request
Nov 14, 2017
Fix resize approval to work for editing requests (cherry picked from commit a983f61)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial "resize approval workflow" feature work is missing some follow-on work needed to allow admin editing of resize/reconfigure requests before approval.
Most of the work is in the associated manageiq-ui-classic PR ManageIQ/manageiq-ui-classic#2598