Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Zone creation #16391

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Fix Zone creation #16391

merged 1 commit into from
Nov 3, 2017

Conversation

chrisarcand
Copy link
Member

settings_for_resource shouldn't blow up if the instance isn't saved yet

It should return the settings from the parent resource instead.
Only attempt to reload the record if the record is persisted

https://bugzilla.redhat.com/show_bug.cgi?id=1509172

@bdunne @Fryguy

@bdunne @chrisarcand
settings_for_resource shouldn't blow up if the instance isn't saved yet
4c610b2 
It should return the settings from the parent resource instead.
Only attempt to reload the record if the record is persisted

https://bugzilla.redhat.com/show_bug.cgi?id=1509172
@miq-bot
Copy link
Member

miq-bot commented Nov 3, 2017

Checked commit chrisarcand@4c610b2 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

bdunne
bdunne approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@Fryguy Fryguy merged commit f8fbc91 into ManageIQ:master Nov 3, 2017
@Fryguy Fryguy added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 3, 2017
gtanzillo
gtanzillo reviewed Nov 3, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@chessbyte chessbyte assigned Fryguy and unassigned gtanzillo Nov 3, 2017
simaishi pushed a commit that referenced this pull request Nov 3, 2017
@Fryguy @simaishi
Merge pull request #16391 from chrisarcand/bz-1509172
e436353 
Fix Zone creation
(cherry picked from commit f8fbc91)

https://bugzilla.redhat.com/show_bug.cgi?id=1509452
@simaishi
Copy link
Contributor

simaishi commented Nov 3, 2017

Gaprindashvili backport details:

$ git log -1
commit e4363530c0ae9e4a48b6e87e8b333b4d196a5f54
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Nov 3 15:23:54 2017 -0400

    Merge pull request #16391 from chrisarcand/bz-1509172
    
    Fix Zone creation
    (cherry picked from commit f8fbc91ab6624f3ebf9a2a4ef0a1676b8d2cf1f5)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1509452

@chrisarcand chrisarcand deleted the bz-1509172 branch November 3, 2017 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo left review comments

@bdunne bdunne bdunne approved these changes

@Fryguy Fryguy Fryguy approved these changes

Assignees

@Fryguy Fryguy

Labels
blocker bug core gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrisarcand @miq-bot @simaishi @Fryguy @gtanzillo @bdunne