Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish simplifying NTP configuration using Settings #16393

Merged
merged 9 commits into from
Nov 27, 2017
Merged

Finish simplifying NTP configuration using Settings #16393

merged 9 commits into from
Nov 27, 2017

Commits on Nov 3, 2017

  1. No more need for server_ntp_settings 

    Everything is pulled from Settings now
https://bugzilla.redhat.com/show_bug.cgi?id=1476365
    @bdunne
    bdunne committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    9dc07c5 View commit details
    Browse the repository at this point in the history

  2. Use the default arg for ntp_reload 

    https://bugzilla.redhat.com/show_bug.cgi?id=1476365
    @bdunne
    bdunne committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    9bb69cc View commit details
    Browse the repository at this point in the history

  3. NTP settings won't be blank and it doesn't matter where they're set 

    https://bugzilla.redhat.com/show_bug.cgi?id=1476365
    @bdunne
    bdunne committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    a49a4b8 View commit details
    Browse the repository at this point in the history

  4. These settings are no longer stored in the settings column 

    https://bugzilla.redhat.com/show_bug.cgi?id=1476365
    @bdunne
    bdunne committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    194f8a6 View commit details
    Browse the repository at this point in the history

  5. Move queue_ntp_reload_if_changed from a callback to a method 

    We are no longer using the `settings` column on the record so the callback
is no longer valid.
https://bugzilla.redhat.com/show_bug.cgi?id=1476365
    @bdunne
    bdunne committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    cb453e1 View commit details
    Browse the repository at this point in the history

  6. server_ntp_settings_blank? is no longer used, there's always a setting 

    https://bugzilla.redhat.com/show_bug.cgi?id=1476365
    @bdunne
    bdunne committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    3263499 View commit details
    Browse the repository at this point in the history

  7. Fetch the ntp_settings from within the method 

    There is now only one caller, so no reason to be an independent method
https://bugzilla.redhat.com/show_bug.cgi?id=1476365
    @bdunne
    bdunne committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    e22c02d View commit details
    Browse the repository at this point in the history

  8. Update MiqServer NTP tests to not be concerned with testing Settings 

    https://bugzilla.redhat.com/show_bug.cgi?id=1476365
    @bdunne
    bdunne committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    b0e2a9f View commit details
    Browse the repository at this point in the history

  9. Add a test to verify the file is only updated when settings have changed 

    https://bugzilla.redhat.com/show_bug.cgi?id=1476365
    @bdunne
    bdunne committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    bb78c4b View commit details
    Browse the repository at this point in the history