-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the pre-defined Auditor role's permissions. #16394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this change. However, it would be good for someone else on the UI team to review because I am not familiar with how the changed identifiers are used in the UI code and cannot asses the impact of the changes.
@h-kataria : can you, please review this? I'ld also like to discuss how to fix all the roles, not just this one. Thx! |
db/fixtures/miq_user_roles.yml
Outdated
- ems_infra_timeline | ||
- ems_physical_infra_console | ||
- ems_physical_infra_show | ||
- ems_physical_infra_show_list | ||
- ems_physical_infra_tag | ||
- ems_physical_infra_timeline | ||
- infra_networking_view | ||
- infra_networking_tag | ||
- instance_view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinpovolny since you already have instance_view, vm_view, image_view, you shouldn't need instance_compare, instance_drift, instance_timeline, instance_perf and same for image_* & vm_*
db/fixtures/miq_user_roles.yml
Outdated
- image_check_compliance | ||
- image_compare | ||
- image_drift | ||
- image_petf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
e9f4ccb
to
502117b
Compare
@h-kataria : thank you for the detailed review! Fixed the issues you found. I also added |
502117b
to
e520a58
Compare
Added some edits:
|
This pull request is not mergeable. Please rebase and repush. |
dccb066
to
15c4c78
Compare
Ping @h-kataria, @gtanzillo. Had to rebase this again. |
15c4c78
to
fa1fa63
Compare
This pull request is not mergeable. Please rebase and repush. |
Ping @h-kataria, @gtanzillo. Is there any point in me rebasing this over and over again or should I close the BZ as "won't fix"? |
@martinpovolny please rebase it one more time, i will merge once Travis turns green. |
* Add miq_template_view and remove it's children. * Replace miq_template_snapshot with miq_template_snapshot_view. * Replace ems_cluster_show and other with ems_cluster_view * Add infra_networking_view and other * Add image_view and other * Add instance_view and other * Add host_view and other
fa1fa63
to
e704564
Compare
Rebased. |
Checked commit martinpovolny@e704564 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Fix the pre-defined Auditor role's permissions. (cherry picked from commit fcc654f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553392
Gaprindashvili backport details:
|
Auditor: Able to see virtual infrastructure for auditing purposes. Can view all infrastructure items. Cannot perform actions on them.
http://talk.manageiq.org/t/product-features-and-roles/2855
https://bugzilla.redhat.com/show_bug.cgi?id=1479583
This fixes just the Auditor role. A more systematic check and fix is needed. A detailed review is very welcome.