Add tag categories for VM migration #16402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign martinpovolny |
|
I have never touched this area. @tinaafitz, @chessbyte : can you, please, reassign? |
jelkosz
reviewed
Nov 7, 2017
db/fixtures/classifications.yml
Outdated
| @@ -943,3 +943,41 @@ | |||
| :parent_id: 0 | |||
| :default: true | |||
| :single_value: "1" | |||
| - :description: Transform VM | |||
There was a problem hiding this comment.
This tag category will be than used also for network and storage mapping, we should use a bit more generic term like:
"Transformation".
smelamud
changed the title
|
Checked commits smelamud/manageiq@5717f35~...2287113 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM. |
|
@miq-bot assign tinaafitz |
|
@smelamud Looks good. |
|
@miq-bot assign martinpovolny |
Added special tag categories for purpose of mapping VMs, networks and storage for mass migration between providers using V2V.
smelamud
force-pushed
the
vm-transform-tags
branch
from
2287113
to
359af3a
Compare
|
Squashed commits. |
|
Gaprindashvili? |
|
@miq-bot add_labels gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Nov 14, 2017
Add tag categories for VM migration (cherry picked from commit 9f42e1b)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added special tag categories for purpose of mapping VMs, networks and storage for mass migration between providers using V2V.