Added Product name to VMDB::Appliance

[juliancheal]

No description provided.

[juliancheal]

@Fryguy something like this ok to access the product name?

[Fryguy]

Oh I like this. 👍

[juliancheal]

This PR is needed for #16410

[chessbyte]

why the UPPER_CASE naming for a method?

[juliancheal]

Copying the convention https://github.com/ManageIQ/manageiq/blob/master/lib/vmdb/appliance.rb#L9-L15

I assume it's because they are effectively constants.

[miq-bot]

Checked commit juliancheal@fe184a5 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

lib/vmdb/appliance.rb

• ❗ - Line 23, Col 14 - Style/MethodName - Use snake_case for method names.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit e0688357e3fe6ae00e52934969d3fe42083ba012
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Fri Nov 17 16:48:41 2017 -0500

    Merge pull request #16409 from juliancheal/add_product_name
    
    Added Product name to VMDB::Appliance
    (cherry picked from commit 64842b73d30b1f0aef849eca7392e4870ad719ce)

[Loicavenel]

@juliancheal can you explain me what is this PR for, I don't really understand the use case?

[juliancheal]

@Loicavenel Hi, we didn't want people using the the internationalisation version method all around the code, to get the product name. I18n.t("product.name") Even though this method just wraps that for now, if there is ever a change to how we internationalise the code or if we change how we generate the name of the product. This way by always using VMDB::Appliance.PRODUCT_NAME we only need to change in one place.

[Loicavenel]

ok make sense