Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceTemplate: add scope for unassigned items. #16445

Merged
merged 1 commit into from
Nov 13, 2017
Merged

ServiceTemplate: add scope for unassigned items. #16445

merged 1 commit into from
Nov 13, 2017

Conversation

martinpovolny
Copy link
Member

@martinpovolny martinpovolny commented Nov 10, 2017 •
edited
Loading

@martinpovolny martinpovolny mentioned this pull request Nov 10, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Nov 10, 2017

Checked commit martinpovolny@d48b32b with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

Ladas
Ladas approved these changes Nov 13, 2017
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, solves the BZs for now.

Another issue is that some layer of the RBAC is cleaning up passed nils. So we could have just 1 scope.

@kbrock kbrock merged commit 46f5a53 into ManageIQ:master Nov 13, 2017
@kbrock kbrock added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 13, 2017
@kbrock kbrock self-assigned this Nov 13, 2017
simaishi pushed a commit that referenced this pull request Nov 14, 2017
@kbrock @simaishi
Merge pull request #16445 from martinpovolny/catalog_unassigned
3b602e1 
ServiceTemplate: add scope for unassigned items.
(cherry picked from commit 46f5a53)

https://bugzilla.redhat.com/show_bug.cgi?id=1513141
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 3b602e1d1d8fab97fd10715ff83ee43df573a0ac
Author: Keenan Brock <keenan@thebrocks.net>
Date:   Mon Nov 13 10:48:49 2017 -0500

    Merge pull request #16445 from martinpovolny/catalog_unassigned
    
    ServiceTemplate: add scope for unassigned items.
    (cherry picked from commit 46f5a537be641c9b5c1fa5d98f452f4852a32458)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1513141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladas Ladas Ladas approved these changes

Assignees

@kbrock kbrock

Labels
bug gaprindashvili/backported lifecycle/services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinpovolny @miq-bot @simaishi @Ladas @kbrock