Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require handsoap in VimConnectMixin #16450

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 12, 2017

Explicitly require handsoap in VimConnectMixin.raw_connect so that we
can catch a Handsoap::Fault exception.

[----] E, [2017-11-10T11:26:47.521471 #13497:10d3134] ERROR -- : MIQ(MiqQueue#deliver) Message id: [1000000000113], Error: [uninitialized constant VimConnectMixin::ClassMethods::Handsoap]
[----] E, [2017-11-10T11:26:47.521689 #13497:10d3134] ERROR -- : [NameError]: uninitialized constant VimConnectMixin::ClassMethods::Handsoap  Method:[block in method_missing]
[----] E, [2017-11-10T11:26:47.521758 #13497:10d3134] ERROR -- : /var/www/miq/vmdb/app/models/mixins/vim_connect_mixin.rb:65:in `rescue in validate_connection'
/var/www/miq/vmdb/app/models/mixins/vim_connect_mixin.rb:61:in `validate_connection'
/var/www/miq/vmdb/app/models/mixins/vim_connect_mixin.rb:51:in `raw_connect'
/var/www/miq/vmdb/app/models/miq_queue.rb:449:in `block in dispatch_method'

https://bugzilla.redhat.com/show_bug.cgi?id=1512019

Explicitly require handsoap in VimConnectMixin.raw_connect so that we
can catch a Handsoap::Fault exception.

https://bugzilla.redhat.com/show_bug.cgi?id=1512019
@agrare
Copy link
Member Author

agrare commented Nov 13, 2017

cc @Fryguy

@miq-bot
Copy link
Member

miq-bot commented Nov 13, 2017

Checked commit agrare@3771aa4 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@blomquisg blomquisg merged commit 0ec867c into ManageIQ:master Nov 15, 2017
@blomquisg blomquisg added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 15, 2017
@agrare agrare deleted the bz_1512019_explicitly_require_handsoap_to_catch_exception branch November 20, 2017 13:07
@simaishi
Copy link
Contributor

gaprindashvili/yes ?

@agrare
Copy link
Member Author

agrare commented Nov 20, 2017

@simaishi yes

simaishi pushed a commit that referenced this pull request Nov 20, 2017
…andsoap_to_catch_exception

Require handsoap in VimConnectMixin
(cherry picked from commit 0ec867c)

https://bugzilla.redhat.com/show_bug.cgi?id=1515444
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit c4139e27bdf15825e4442621b4c30290cee66217
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Wed Nov 15 17:20:58 2017 -0500

    Merge pull request #16450 from agrare/bz_1512019_explicitly_require_handsoap_to_catch_exception
    
    Require handsoap in VimConnectMixin
    (cherry picked from commit 0ec867c72982e7914fd3524cbc5d28efd422aef2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1515444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants