Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce $nuage_log that logs into log/nuage.log #16455

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Introduce $nuage_log that logs into log/nuage.log #16455

merged 1 commit into from
Feb 9, 2018

Conversation

miha-plesko
Copy link
Contributor

@miha-plesko miha-plesko commented Nov 13, 2017 •
edited
Loading

With this commit we introduce yet another global logger that is to be used by Nuage provider. We're having quite some logs there and it's better to log them into its own file.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1534449
@miq-bot add_label enhancement
@miq-bot assign @blomquisg

/cc @gberginc

@miha-plesko
Copy link
Contributor Author

/cc @gberginc @gasper-vrhovsek

gberginc
gberginc approved these changes Nov 27, 2017
View reviewed changes
Copy link
Contributor

@gberginc gberginc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blomquisg this was actually a request that was made from the Red Hat support team during the official walkthrough session.

/cc @bronaghs

@blomquisg blomquisg assigned Fryguy and unassigned blomquisg Dec 4, 2017
@blomquisg
Copy link
Member

@gberginc, @miha-plesko I guess this needs to be added to the .rubocop_local file.

@Fryguy Adding a provider-specific logger for Nuage related logging. Any additional things you can think of in the base repo that need to be taken care of?

@miq-bot miq-bot assigned blomquisg and unassigned Fryguy Dec 4, 2017
@blomquisg blomquisg assigned Fryguy and unassigned blomquisg Dec 4, 2017
@gberginc
Copy link
Contributor

gberginc commented Dec 8, 2017

@blomquisg as @miha-plesko is away this week, I pushed the change as you suggested.

@miq-bot
Copy link
Member

miq-bot commented Dec 13, 2017

This pull request is not mergeable. Please rebase and repush.

@miha-plesko miha-plesko mentioned this pull request Dec 13, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2018

This pull request is not mergeable. Please rebase and repush.

@miha-plesko
Introduce $nuage_log that logs into log/nuage.log
a0f4979 
With this commit we introduce yet another global logger
that is to be used by nuage provider. We're having quite
some logs there and it's better to log them into its own
file.

Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
@miha-plesko
Copy link
Contributor Author

Seems like we just forgot to hit the Merge button on this one. Rebased and repushed to resolve merge conflicts, @Fryguy could you please hit the button when you can? ⏯

@miq-bot
Copy link
Member

miq-bot commented Jan 12, 2018

Checked commit miha-plesko@a0f4979 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@chargio
Copy link
Contributor

chargio commented Jan 12, 2018

@blomquisg Can we review this?

@miha-plesko
Copy link
Contributor Author

We now have a BZ for this PR: https://bugzilla.redhat.com/show_bug.cgi?id=1534449

@miha-plesko
Copy link
Contributor Author

Ping 😇

@carbonin carbonin assigned carbonin and unassigned Fryguy Feb 9, 2018
@carbonin carbonin merged commit 2099b3e into ManageIQ:master Feb 9, 2018
@carbonin carbonin added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 9, 2018
@chargio
Copy link
Contributor

chargio commented Feb 10, 2018

@miq-bot add/label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Feb 10, 2018

@chargio unrecognized command 'add', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@miha-plesko
Copy link
Contributor Author

@miq-bot add_label gaprindashvili/yes

@miha-plesko miha-plesko mentioned this pull request Feb 12, 2018
Merged
simaishi pushed a commit that referenced this pull request Mar 7, 2018
@carbonin @simaishi
Merge pull request #16455 from miha-plesko/nuage-logger
2d19725 
Introduce $nuage_log that logs into log/nuage.log
(cherry picked from commit 2099b3e)

https://bugzilla.redhat.com/show_bug.cgi?id=1552336
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 2d1972560802b1bad7428cc451d38f833a9535c5
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Fri Feb 9 16:21:43 2018 -0500

    Merge pull request #16455 from miha-plesko/nuage-logger
    
    Introduce $nuage_log that logs into log/nuage.log
    (cherry picked from commit 2099b3e9ec320c0b62f7074563fa9e37ba503b3c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552336

@miha-plesko miha-plesko deleted the nuage-logger branch January 7, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonin carbonin carbonin approved these changes

@gberginc gberginc gberginc approved these changes

Assignees

@carbonin carbonin

Labels
bug enhancement gaprindashvili/backported providers/network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@miha-plesko @blomquisg @gberginc @miq-bot @chargio @simaishi @carbonin @Fryguy