Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string interpolations #16468

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

mzazrivec
Copy link
Contributor

String interpolations aren't allowed in a gettext string. This fix also needs to land in gaprindashvili.

Fixes #16459

@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2017

Checked commit mzazrivec@0530342 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍪

@chessbyte chessbyte self-assigned this Nov 14, 2017
@chessbyte chessbyte merged commit 44c7c81 into ManageIQ:master Nov 14, 2017
@chessbyte chessbyte added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 14, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
Fix string interpolations
(cherry picked from commit 44c7c81)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit ff23a1c807e7e2e820e497415ffa92dc03b3acba
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Tue Nov 14 17:09:48 2017 +0200

    Merge pull request #16468 from mzazrivec/fix_string_interpolations
    
    Fix string interpolations
    (cherry picked from commit 44c7c81839998d991f3bf25946d5c118a6fd2cb8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locale update leaking Ruby object
4 participants