Imports old associations #16471
Merged
Imports old associations #16471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
|
@eclarizio can you review, pretty please? |
eclarizio
reviewed
Nov 14, 2017
There was a problem hiding this comment.
Think you can add a spec around the other "associations" spec (on master it's at line 187) that actually checks to make sure the right association was made? That's the whole point of doing the .position and everything, so I feel like it would be good to have a spec around it.
d-m-u
force-pushed
the
import_old_df_associations
branch
from
d3f0dcb
to
bc87471
Compare
d-m-u
force-pushed
the
import_old_df_associations
branch
from
bc87471
to
83106af
Compare
|
Checked commit d-m-u@83106af with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label gaprindashvili/yes |
|
thanks @eclarizio ✨ |
simaishi
pushed a commit
that referenced
this pull request
Nov 17, 2017
Imports old associations (cherry picked from commit 6edddb7)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the dialog field association import code to also deal with the now-defunct associations listed as trigger_auto_refresh and auto_refresh. It's the same code as the recent data migration that does this import and should allow people to import old dialogs and have the associations converted to use the new table.