Add two new types to MW server factories

[karelhala]

Merge first

This PR enables 2 new middleware server types for testing purposes in ui-classic repository.

[karelhala]

@miq-bot add_label bug,gaprindashvili/yes, providers/middleware

[karelhala]

@abonas this PR is required to be merged before ManageIQ/manageiq-ui-classic#2724 so we can update tests of topology.

[miq-bot]

Checked commit karelhala@722ab56 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

[abonas]

@miq-bot add_label test
LGTM
@israel-hdez please review as well.
@miq-bot assign @chessbyte

[xeviknal]

If I am not wrong, you can move those three inherited factories within the middleware_server factory and then remove the parent => :middleware_server attribute from each child factory definition.

Here a bit of more context:
https://github.com/thoughtbot/factory_bot/blob/master/GETTING_STARTED.md#inheritance

Do you think it worth to change it?

[abonas]

@xeviknal I think the way it is done here in the PR is the same as the rest of miq does, so imo it is not worth to change it for consistency reasons. but I'd like to hear what @agrare thinks :)

[agrare]

@abonas is right we (rightly or wrongly) follow this pattern, e.g. see the orchestration_stack factory https://github.com/ManageIQ/manageiq/blob/master/spec/factories/orchestration_stack.rb
👍 on this for consistency

[israel-hdez]

For me, it's OK.

[agrare]

@abonas is right we (rightly or wrongly) follow this pattern, e.g. see the orchestration_stack factory https://github.com/ManageIQ/manageiq/blob/master/spec/factories/orchestration_stack.rb
👍 on this for consistency

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit ee87b92508b79bae96f3df58331f4e72a97493d1
Author: Adam Grare <agrare@redhat.com>
Date:   Sun Nov 19 09:44:14 2017 -0500

    Merge pull request #16478 from karelhala/eapWildflyFactory
    
    Add two new types to MW server factories
    (cherry picked from commit 2a3700be7f9dcadcf6815ebc245b4224af7511f9)

[abonas]

@agrare could you please add a milestone here? I believe it belongs to 74. thanks