Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ems_infra_admin_ui feature to role assignment #16484

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Update ems_infra_admin_ui feature to role assignment #16484

merged 1 commit into from
Nov 16, 2017

Conversation

vojtechszocs
Copy link
Contributor

Update ems_infra_admin_ui feature to role assignment:

  • add EvmRole-administrator
  • remove EvmRole-operator

@vojtechszocs
Assign ems_infra_admin_ui feature to EvmRole-administrator
b2c9393 
Signed-off-by: Vojtech Szocs <vojtech.szocs@gmail.com>
@vojtechszocs
Copy link
Contributor Author

cc @oourfali @agrare

@oourfali
Copy link

@agrare can you merge this one? pretty straight forward.

agrare
agrare approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge when green

@agrare agrare self-assigned this Nov 16, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 16, 2017

Checked commit vojtechszocs@b2c9393 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@agrare agrare merged commit cb5e0de into ManageIQ:master Nov 16, 2017
@agrare agrare added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 16, 2017
@vojtechszocs vojtechszocs mentioned this pull request Nov 16, 2017
Closed
6 tasks
@vojtechszocs
Copy link
Contributor Author

@simaishi we would like to backport this to 5.9 but I can't find a way how to add the gaprindashvili/yes label. Can you please assist?

@oourfali
Copy link

@miq-bot add_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Nov 17, 2017
@agrare @simaishi
Merge pull request #16484 from vojtechszocs/update-role-for-admin-ui
b6f9a0a 
Update ems_infra_admin_ui feature to role assignment
(cherry picked from commit cb5e0de)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit b6f9a0aad032b20bf9910670ab6e35cc15838c33
Author: Adam Grare <agrare@redhat.com>
Date:   Thu Nov 16 09:28:06 2017 -0500

    Merge pull request #16484 from vojtechszocs/update-role-for-admin-ui
    
    Update ems_infra_admin_ui feature to role assignment
    (cherry picked from commit cb5e0de1766fa363ecfd19715316e17053925d1e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@oourfali oourfali oourfali approved these changes

Assignees

@agrare agrare

Labels
enhancement gaprindashvili/backported providers/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vojtechszocs @oourfali @miq-bot @simaishi @agrare @Fryguy