Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the column reordering tool and the schema structure validations #16488

Merged

Conversation

carbonin
Copy link
Member

Version 2.0 and greater of pglogical doesn't require that the columns of a replicated table be in the same order on the source and destination databases.

All of this was written to guard against and correct this situation so now it can be removed.

Related schema PR ManageIQ/manageiq-schema#129

ref: 2ndQuadrant/pglogical@88ff7ff

Version 2.0 and greater of pglogical doesn't require that the columns
of a replicated table be in the same order on the source and destination
databases.

All of this was written to guard against and correct this situation
so now it can be removed.

ref: 2ndQuadrant/pglogical@88ff7ff
@miq-bot
Copy link
Member

miq-bot commented Nov 16, 2017

Checked commit carbonin@eaefbd0 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@Fryguy
Copy link
Member

Fryguy commented Nov 16, 2017

😍

@Fryguy Fryguy merged commit 5deab50 into ManageIQ:master Nov 16, 2017
@Fryguy Fryguy added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 16, 2017
simaishi pushed a commit that referenced this pull request Nov 17, 2017
…er_checks

Remove the column reordering tool and the schema structure validations
(cherry picked from commit 5deab50)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 82576581893046d230b94aa1afba2f55be33c997
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Nov 16 16:16:45 2017 -0500

    Merge pull request #16488 from carbonin/remove_replication_column_order_checks
    
    Remove the column reordering tool and the schema structure validations
    (cherry picked from commit 5deab5072d7cb7d6dbb40ec197ad7eb81b78c225)

@carbonin carbonin deleted the remove_replication_column_order_checks branch December 1, 2017 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants