Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require miq_fault_tolerant_vim in raw_connect #16500

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 20, 2017

Need to require miq_fault_tolerant_vim in raw_connect to validate credentials.

WARN -- :MIQ(ManageIQ::Providers::Vmware::InfraManager.validate_connection) #<NameError: uninitialized constant VimConnectMixin::ClassMethods::MiqVim>

https://bugzilla.redhat.com/show_bug.cgi?id=1512019

Need to require miq_fault_tolerant_vim in raw_connect to validate
credentials.

`WARN -- :MIQ(ManageIQ::Providers::Vmware::InfraManager.validate_connection) #<NameError: uninitialized constant VimConnectMixin::ClassMethods::MiqVim>`

https://bugzilla.redhat.com/show_bug.cgi?id=1512019
@miq-bot
Copy link
Member

miq-bot commented Nov 20, 2017

Checked commit agrare@2f52e7c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@blomquisg blomquisg merged commit dbaa1fc into ManageIQ:master Nov 20, 2017
@blomquisg blomquisg added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 20, 2017
@agrare agrare deleted the require_miq_fault_tolerant_vim_raw_connect branch November 20, 2017 19:37
simaishi pushed a commit that referenced this pull request Nov 20, 2017
…raw_connect

Require miq_fault_tolerant_vim in raw_connect
(cherry picked from commit dbaa1fc)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit df2b50adf2dfa693c43a94f4466333d8042f9bcf
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Mon Nov 20 10:22:49 2017 -0500

    Merge pull request #16500 from agrare/require_miq_fault_tolerant_vim_raw_connect
    
    Require miq_fault_tolerant_vim in raw_connect
    (cherry picked from commit dbaa1fc44c405d9b9c8ec8b0cc724b28da9d8fb9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants