Max queued targets threshold #16502
Closed
Max queued targets threshold #16502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tie MiqQueue to BinaryBlob
Fill resource id only to new targets, to avoid growing query.
Add max_queued_targets_threshold, making sure we have a top limit of max queued items. The current solution can have issues with a lot of queued targets (big processing time and memory) Also if the refresh worker goes down (consumer) we want to make sure the producers will not be queueing targets indefinitelly. Cause in that case, that would be causing the producers to rise in Memory and procidessing time would be rising. So we would be forced to delete the queue item with a lot of targets anyway.
|
Checked commits Ladas/manageiq@f7ce67b~...762b454 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 **
app/models/ems_refresh.rb
spec/models/ems_refresh_spec.rb
spec/models/manager_refresh/target_spec.rb
|
|
This pull request is not mergeable. Please rebase and repush. |
|
Believe this was superseded by #16432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add max_queued_targets_threshold, making sure we have a top limit
of max queued items. The current solution can have issues with
a lot of queued targets (big processing time and memory)
Also if the refresh worker goes down (consumer) we want to make sure
the producers will not be queueing targets indefinitelly. Cause in
that case, that would be causing the producers to rise in Memory
and procidessing time would be rising. So we would be forced to
delete the queue item with a lot of targets anyway.
Only last commit is relevant.
Depends on