Move the notifications to include more of the setup #16508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things can go wrong while setting up the default objects and setting up the provider. We should wait until all of this work is done before creating the notification that says that the role has been successfully enabled. https://bugzilla.redhat.com/show_bug.cgi?id=1458019
|
Checked commit carbonin@6c6d66a with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Nov 20, 2017
|
|
|
Sure? |
simaishi
pushed a commit
that referenced
this pull request
Nov 27, 2017
Move the notifications to include more of the setup (cherry picked from commit b5c8317) https://bugzilla.redhat.com/show_bug.cgi?id=1517817
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things can go wrong while setting up the default objects and setting up the provider.
We should wait until all of this work is done before creating the notification that says that the role has been successfully enabled.
https://bugzilla.redhat.com/show_bug.cgi?id=1458019