Binary blob purging #16524
Merged
Binary blob purging #16524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
commented
Nov 22, 2017
| end | ||
|
|
||
| def purge_scope(_older_than = nil) | ||
| where(:resource => nil) |
There was a problem hiding this comment.
TODO define purge_associated_records, see https://github.com/ManageIQ/manageiq/pull/16413/files#r151449186
There was a problem hiding this comment.
Let's get this in as part of this PR.
|
How is there no method called |
agrare
force-pushed
the
binary_blob_purging
branch
from
493ca22
to
59933e4
Compare
|
Checked commits agrare/manageiq@ef11121~...59933e4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
👍 Done @Fryguy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scheduled purging of BinaryBlobs which have no associated resource