Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where plugin settings had higher precedence than manageiq #16535

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Nov 27, 2017

One of the side effects of this is that in production deployments with
overrides, the overrides were being clobbered by the plugins.

https://bugzilla.redhat.com/show_bug.cgi?id=1517938

One of the side effects of this is that in production deployments with
overrides, the overrides were being clobbered by the plugins.

https://bugzilla.redhat.com/show_bug.cgi?id=1517938
@miq-bot
Copy link
Member

miq-bot commented Nov 27, 2017

Checked commit Fryguy@63759e4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@gtanzillo gtanzillo added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 28, 2017
@gtanzillo gtanzillo merged commit a9a2bff into ManageIQ:master Nov 28, 2017
@Fryguy Fryguy deleted the fix_settings_order branch November 28, 2017 14:40
simaishi pushed a commit that referenced this pull request Nov 28, 2017
Fix issue where plugin settings had higher precedence than manageiq
(cherry picked from commit a9a2bff)

https://bugzilla.redhat.com/show_bug.cgi?id=1518290
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit a53c92e09bd4de306a819041b992c4a9d6db0fec
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Tue Nov 28 09:13:25 2017 -0500

    Merge pull request #16535 from Fryguy/fix_settings_order
    
    Fix issue where plugin settings had higher precedence than manageiq
    (cherry picked from commit a9a2bffbe6f0677b45d7c36d90b04eef71d5cfc9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants