Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vm_destroy event to MiqEventDefinition. #16557

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

lfu
Copy link
Member

@lfu lfu commented Nov 29, 2017

Add missing vm_destroy event.

For clarity, vm_delete is the policy event when a VM is removed from inventory from MIQ UI.
vm_destroy is the policy event raised when a VM is deleted from disk from VMware side.
vm_unregister is the policy event raised when a VM is removed from inventory from VMware side.

Includes ManageIQ/manageiq-content#223.
https://bugzilla.redhat.com/show_bug.cgi?id=1506520

@miq-bot assign @gmcculloug
@miq-bot add_label bug, fine/yes, gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Dec 2, 2017

Checked commit lfu@7a5f447 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@gmcculloug
Copy link
Member

@lfu Thanks for the clarification in the description. Want to note that vm_delete is commented out in miq_event_definitions.csv which makes sense as the VM object would no longer exist.

@gmcculloug gmcculloug merged commit a756cf9 into ManageIQ:master Dec 21, 2017
@gmcculloug gmcculloug added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 21, 2017
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit b19456cf334cbd6e933bb5f0c6c0043a4f06ad52
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Dec 21 09:13:57 2017 -0500

    Merge pull request #16557 from lfu/destroy_vm_1506520
    
    Add vm_destroy event to MiqEventDefinition.
    (cherry picked from commit a756cf9f2d0f4f2f47ebfed6237dba66135c7504)

simaishi pushed a commit that referenced this pull request Jan 3, 2018
Add vm_destroy event to MiqEventDefinition.
(cherry picked from commit a756cf9)
simaishi pushed a commit that referenced this pull request Jan 15, 2018
Add vm_destroy event to MiqEventDefinition.
(cherry picked from commit a756cf9)

https://bugzilla.redhat.com/show_bug.cgi?id=1534584
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit c48c261329b3adf6ffc187677f27a869c2bbdbc1
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Dec 21 09:13:57 2017 -0500

    Merge pull request #16557 from lfu/destroy_vm_1506520
    
    Add vm_destroy event to MiqEventDefinition.
    (cherry picked from commit a756cf9f2d0f4f2f47ebfed6237dba66135c7504)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1534584

d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
@lfu lfu deleted the destroy_vm_1506520 branch September 29, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants