Skip seeding of categories if their creation is invalid #16568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: This is somewhat hacky and definitely an exception in what we've deemed 'standard practice' with our unusual seeding procedure. This change skips seeding of categories in the event that creating them would be invalid - and they would be invalid because people would like to use their own categories with the same name. Because categories here in seeding are looked up via name (delegated to tag), a new category with the same name is attempted to be made, fails silently, and gives a weird error when entries are attempted to be added to an initialized but unpersisted category record. https://bugzilla.redhat.com/show_bug.cgi?id=1507240
|
Checked commit chrisarcand@b093eda with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/classification.rb
spec/models/classification_spec.rb
|
gtanzillo
approved these changes
Nov 30, 2017
|
Thanks @chrisarcand 👍 |
jrafanie
reviewed
Nov 30, 2017
| # This tests that if seeding category and it's invalid (due to uniqueness constraints) | ||
| # then seeding still doesn't fail. | ||
| cat = Classification.find_by!(:description => "Cost Center", :parent_id => 0) | ||
| allow(YAML).to receive(:load_file).and_call_original |
|
Looks like code. |
simaishi
pushed a commit
that referenced
this pull request
Dec 1, 2017
Skip seeding of categories if their creation is invalid (cherry picked from commit 48846ec) https://bugzilla.redhat.com/show_bug.cgi?id=1519875
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Dec 7, 2017
Skip seeding of categories if their creation is invalid (cherry picked from commit 48846ec) https://bugzilla.redhat.com/show_bug.cgi?id=1523402
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…-seeding Skip seeding of categories if their creation is invalid (cherry picked from commit 48846ec) https://bugzilla.redhat.com/show_bug.cgi?id=1523402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: This is somewhat hacky and definitely an exception in what we've deemed 'standard practice' with our unusual seeding procedure.
This change skips seeding of categories in the event that creating them would be invalid - and they would be invalid because people would like to use their own categories with the same name. Because categories here in seeding are looked up via name (delegated to tag), a new category with the same name is attempted to be made, fails silently, and gives a weird error when entries are attempted to be added to an initialized but unpersisted category record.
https://bugzilla.redhat.com/show_bug.cgi?id=1507240
cc/ @jrafanie