Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return a duplicate object from MiqGroup#settings #16572

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Don't return a duplicate object from MiqGroup#settings #16572

merged 2 commits into from
Dec 1, 2017

Commits on Nov 30, 2017

  1. Add spec to ensure MiqGroup#settings doesn't return a duplicate object 

    https://bugzilla.redhat.com/show_bug.cgi?id=1516793
    @carbonin
    carbonin committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    66f86e4 View commit details
    Browse the repository at this point in the history

  2. Redefine MiqGroup #settings and #settings= 

    This commit ensures that #settings returns the same object that
exists in the object.

This ensures that calls like the following will work as expected:

group.settings[:a] = 1

Previously, #settings returned the duplicate object created by
Hash#with_indifferent_access

https://bugzilla.redhat.com/show_bug.cgi?id=1516793
    @carbonin
    carbonin committed Nov 30, 2017
    Configuration menu
    Copy the full SHA
    57c8d63 View commit details
    Browse the repository at this point in the history