Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Set EMS status when during orchestrate_destroy #16574

Closed
wants to merge 1 commit into from

Conversation

agrare
Copy link
Member

@agrare agrare commented Dec 1, 2017

Set the ems status to deleting while the workers are shutting down.
This can be used for display as well as preventing the user from
accidentally re-enabling an EMS which is being deleted.

Depends: ManageIQ/manageiq-schema#140

@agrare
Copy link
Member Author

agrare commented Dec 1, 2017

I'd like to add a task to track the destroy that can be seen by users, probably need to change the args to allow a userid to be passed in from the UI.

@agrare agrare changed the title Set EMS status when during orchestrate_destroy [WIP] Set EMS status when during orchestrate_destroy Dec 1, 2017
@agrare agrare added the wip label Dec 1, 2017
@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2017

This pull request is not mergeable. Please rebase and repush.

@chessbyte
Copy link
Member

@agrare Please rebase and re-push

Set the ems status to deleting while the workers are shutting down.
This can be used for display as well as preventing the user from
accidentally re-enabling an EMS which is being deleted.
@miq-bot
Copy link
Member

miq-bot commented Jan 25, 2018

Checked commit agrare@b1eba2c with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@agrare
Copy link
Member Author

agrare commented Jan 25, 2018

Rebased but the need for this might be negated by #16755 since it looks like we don't wait for the workers to shutdown anymore. @jameswnl can you confirm?

@jameswnl
Copy link
Contributor

@agrare we are killing the workers right now. The killing does have a sleep loop to make sure it's done, albeit the wait shouldn't be apparent to user.

However, it seems it still can take some time to finish depending on how much associated resources are being cleaned up along the provider destroy.

@agrare
Copy link
Member Author

agrare commented Jan 26, 2018

👍 thanks @jameswnl

@agrare
Copy link
Member Author

agrare commented Apr 9, 2018

Going to close this for now since it isn't getting any traction. If we find we need this in the future I will re-open it.

@agrare agrare closed this Apr 9, 2018
@agrare agrare deleted the ems_status_deleting branch August 14, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants