-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Set EMS status when during orchestrate_destroy #16574
Conversation
da13d9a
to
ec2df1c
Compare
I'd like to add a task to track the destroy that can be seen by users, probably need to change the args to allow a userid to be passed in from the UI. |
ec2df1c
to
4ebf3b8
Compare
This pull request is not mergeable. Please rebase and repush. |
@agrare Please rebase and re-push |
Set the ems status to deleting while the workers are shutting down. This can be used for display as well as preventing the user from accidentally re-enabling an EMS which is being deleted.
4ebf3b8
to
b1eba2c
Compare
Checked commit agrare@b1eba2c with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
@agrare we are killing the workers right now. The killing does have a sleep loop to make sure it's done, albeit the wait shouldn't be apparent to user. However, it seems it still can take some time to finish depending on how much associated resources are being cleaned up along the provider destroy. |
👍 thanks @jameswnl |
Going to close this for now since it isn't getting any traction. If we find we need this in the future I will re-open it. |
Set the ems status to deleting while the workers are shutting down.
This can be used for display as well as preventing the user from
accidentally re-enabling an EMS which is being deleted.
Depends: ManageIQ/manageiq-schema#140