Let ActiveRecord handle serializing settings as HashWithIndifferentAccess #16593
Conversation
|
Checked commit bdunne@3abda3c with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
I'm going to 👍 this but I do have some reservations that I want to note:
In c0a662b I was acknowledging that my fix was not entirely satisfactory to me. The much more extensive fix that I wanted was for all settings to be keyed with strings, allowing for a much more natural serialization/deserialization to/from JSON, and fewer surprises.
The bigger picture is that this is a general problem with any serialized column, which are used extensively, and indeed bugs like this tend to crop up wherever we use them. What I'd really like is a general solution to this problem that we can apply (eventually) everywhere, aiming for consistency. With that in mind I think an extensive use of HashWithIndifferentAccess would be regrettable, if using regular hashes keyed with strings was satisfactory. But I'm also acknowledging that this would be more work, and more prone to breaking things.
|
Change of opinion. I don't think this hash should contain string keys at all, closing. |
Require ManageIQ/manageiq-schema#141
Followup to #16572