-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Catalog tab of Publish VM dialog #16599
Merged
gmcculloug
merged 1 commit into
ManageIQ:master
from
masayag:update_publish_vm_catalog_tab
Dec 7, 2017
Merged
Update Catalog tab of Publish VM dialog #16599
gmcculloug
merged 1 commit into
ManageIQ:master
from
masayag:update_publish_vm_catalog_tab
Dec 7, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several changes were made to the Catalog tab of the publish-vm dialog. The purpose of those changes is to describe the creation of the template as the main goal of this dialog. Fixes bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1518081 https://bugzilla.redhat.com/show_bug.cgi?id=1518077
@miq-bot add_labels gaprindashvili/yes, bug |
@borod108 please review |
borod108
approved these changes
Dec 5, 2017
Checked commit masayag@ccae292 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@miq-bot assign @gmcculloug |
simaishi
pushed a commit
that referenced
this pull request
Dec 11, 2017
Update Catalog tab of Publish VM dialog (cherry picked from commit 8ec14c8)
Gaprindashvili backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes were made to the Catalog tab of the publish-vm dialog.
The purpose of those changes is to describe the creation of the template
as the main goal of this dialog.
Fixes bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1518081
https://bugzilla.redhat.com/show_bug.cgi?id=1518077