Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Catalog tab of Publish VM dialog #16599

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

masayag
Copy link
Contributor

@masayag masayag commented Dec 5, 2017

Several changes were made to the Catalog tab of the publish-vm dialog.
The purpose of those changes is to describe the creation of the template
as the main goal of this dialog.

Fixes bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1518081
https://bugzilla.redhat.com/show_bug.cgi?id=1518077

publish_vm_catalog_tab2

Several changes were made to the Catalog tab of the publish-vm dialog.
The purpose of those changes is to describe the creation of the template
as the main goal of this dialog.

Fixes bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1518081
https://bugzilla.redhat.com/show_bug.cgi?id=1518077
@masayag
Copy link
Contributor Author

masayag commented Dec 5, 2017

@miq-bot add_labels gaprindashvili/yes, bug

@masayag
Copy link
Contributor Author

masayag commented Dec 5, 2017

@borod108 please review

@masayag
Copy link
Contributor Author

masayag commented Dec 5, 2017

@masayag
Copy link
Contributor Author

masayag commented Dec 5, 2017

@miq-bot
Copy link
Member

miq-bot commented Dec 5, 2017

Checked commit masayag@ccae292 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@masayag
Copy link
Contributor Author

masayag commented Dec 7, 2017

@miq-bot assign @gmcculloug

@gmcculloug gmcculloug merged commit 8ec14c8 into ManageIQ:master Dec 7, 2017
@gmcculloug gmcculloug added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 7, 2017
simaishi pushed a commit that referenced this pull request Dec 11, 2017
Update Catalog tab of Publish VM dialog
(cherry picked from commit 8ec14c8)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 55cf980e7a9cc204f3e149095f21ffbc2a326c21
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Dec 7 11:00:45 2017 -0500

    Merge pull request #16599 from masayag/update_publish_vm_catalog_tab
    
    Update Catalog tab of Publish VM dialog
    (cherry picked from commit 8ec14c859726d9c8936b06f885194d8805c49ec0)

@masayag masayag deleted the update_publish_vm_catalog_tab branch June 27, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants