Handle autoload error not caught by safe_constantize #16608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiqExpression currently supports 'values' that are 'fields', i.e.:
```ruby
{"=" => {"field" => "Vm-name", "value" => "Vm-description"}}
```
It will however trip up on a value/field if it *looks* like it
contains a constant that can be autoloaded, but can't:
```ruby
{"=" => {"field" => "Vm-name", "value" => "VM-test"}}
```
...
```ruby
"VM".safe_constantize # => LoadError: Unable to autoload constant VM, expected /home/tim/src/manageiq/app/models/vm.rb to define it
```
We need to explicitly catch this `LoadError`, which does not inherit
from `StandardError`, returning `nil`, to prevent MiqExpression from
trying to interpret this as a "field value".
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1521167
|
Checked commit imtayadeway@54bd9d3 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Fryguy
approved these changes
Dec 6, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 11, 2017
…alues Handle autoload error not caught by safe_constantize (cherry picked from commit 7a5fd37) https://bugzilla.redhat.com/show_bug.cgi?id=1522846
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiqExpression currently supports 'values' that are 'fields', i.e.:
It will however trip up on a value/field if it looks like it
contains a constant that can be autoloaded, but can't:
...
We need to explicitly catch this
LoadError, which does not inheritfrom
StandardError, returningnil, to prevent MiqExpression fromtrying to interpret this as a "field value".
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1521167