Changing the key of network device to be both ipv4 + ipv6

[AlonaKaplan]

A network device may not have ipv4 addresses at all, using ipv4 as the sole
key is not enough.

[AlonaKaplan]

@pkliczewski @Ladas please review. This is needed for the regular (non graph) refresh.

[Ladas]

@AlonaKaplan can you verify this doesn't break Vmware/Rhev providers specs? (you will need to run them locally)

[pkliczewski]

The change looks good, please make sure that there are no regressions as @Ladas suggested.

[AlonaKaplan]

Both vmware and ovirt specs pass. oVirt was also verified manually (web ui).

[miq-bot]

Checked commit AlonaKaplan@3ec67f4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[agrare]

LGTM great change @AlonaKaplan !

[chargio]

Shouldn't this be either, not both?
You can have IPv4, IPv6, or both, they are independent

[agrare]

@chargio we store both ipv4 and ipv6 addresses in the network record for a guest device, see https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/app/models/manageiq/providers/vmware/infra_manager/refresh_parser.rb#L1131-L1147

[chargio]

@agrare I was concerned that the identification is for all of them. A server with an IPv4 address and a server with the IPv6 address are the same, even if one of them is not working. There are differnt endpoints for the same server.

[agrare]

Sorry @chargio you lost me :D A NIC can have multiple ip addresses, can be more than one ipv4 address, a mix of ipv4 and ipv6 addresses, etc...

[AlonaKaplan]

@miq-bot add_label gaprindashvili/yes

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit f05b40ef0e67495de4e5f2f48bb0b92940502636
Author: Adam Grare <agrare@redhat.com>
Date:   Tue Dec 12 08:44:03 2017 -0500

    Merge pull request #16619 from AlonaKaplan/ips
    
    Changing the key of network device to be both ipv4 + ipv6
    (cherry picked from commit a270061b26f89a05b270f5168e6c9ba70d8213c5)