Use the server IP for the AWX database host when the rails config is no good #16621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no good Previously we would check the database configuration (database.yml) then if that host wasn't set or was localhost we would try to use the docker host gateway. But we have a better option. We can use the server's ip instead. This leaves the docker gateway as the last option as that will probably still be needed for development environments.
|
Checked commit carbonin@a8caa1f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Dec 8, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 11, 2017
…e_host Use the server IP for the AWX database host when the rails config is no good (cherry picked from commit 5842a94)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would check the database configuration (database.yml)
then if that host wasn't set or was localhost we would try to use the
docker host gateway.
But we have a better option. We can use the server's ip instead.
This leaves the docker gateway as the last option as that will probably
still be needed for development environments.
Before this change AWX was failing on appliances if the appliance was running the database locally.