Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user roles to proper access physical infrastructure views #16637

Merged

Conversation

saulotoledo
Copy link
Member

@saulotoledo saulotoledo commented Dec 11, 2017

Prior to this update, some roles were unable to see the available infrastructure views in the menu (Compute -> Physical Infrastructure).

This patch adds the proper permissions to each role in order to allow that.

Resolves:
Red Hat Bugzilla – Bug 1505618
Red Hat Bugzilla – Bug 1505619

@saulotoledo saulotoledo changed the title Allow EvmRole-reader to have access to physical infrastructure views WIP: Allow EvmRole-reader to have access to physical infrastructure views Dec 11, 2017
@saulotoledo saulotoledo changed the title WIP: Allow EvmRole-reader to have access to physical infrastructure views [WIP] Allow EvmRole-reader to have access to physical infrastructure views Dec 11, 2017
@miq-bot miq-bot added the wip label Dec 11, 2017
@saulotoledo saulotoledo force-pushed the evmrole-reader_access_to_physical_infra branch from 4fe0bb6 to f8674db Compare December 11, 2017 19:34
@saulotoledo saulotoledo changed the title [WIP] Allow EvmRole-reader to have access to physical infrastructure views Allow EvmRole-reader to have access to physical infrastructure views Dec 11, 2017
@miq-bot
Copy link
Member

miq-bot commented Dec 11, 2017

Checked commit saulotoledo@f8674db with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@saulotoledo saulotoledo changed the title Allow EvmRole-reader to have access to physical infrastructure views Update user roles to proper access physical infrastructure views Dec 11, 2017
@miq-bot miq-bot removed the wip label Dec 11, 2017
@rodneyhbrown7
Copy link

@miq-bot add_label gaprindashvilli/yes

@miq-bot
Copy link
Member

miq-bot commented Dec 11, 2017

@rodneyhbrown7 Cannot apply the following label because they are not recognized: gaprindashvilli/yes

@agrare
Copy link
Member

agrare commented Dec 21, 2017

Hey @h-kataria I'm not very familiar with the user roles, can you take a look?

@h-kataria
Copy link
Contributor

Looks good, This should also fix https://bugzilla.redhat.com/show_bug.cgi?id=1525657

@h-kataria h-kataria self-assigned this Dec 21, 2017
@h-kataria h-kataria added this to the Sprint 76 Ending Jan 1, 2018 milestone Dec 21, 2017
@h-kataria h-kataria merged commit 12bfa52 into ManageIQ:master Dec 21, 2017
@saulotoledo
Copy link
Member Author

saulotoledo commented Dec 21, 2017

Thank you very much @h-kataria , @agrare and @rodneyhbrown7 .

simaishi pushed a commit that referenced this pull request Jan 3, 2018
@simaishi
Copy link
Contributor

simaishi commented Jan 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 75e7503ade86eeb93f0233c2c866795f3614db0d
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Dec 21 13:57:05 2017 -0500

    Merge pull request #16637 from saulotoledo/evmrole-reader_access_to_physical_infra
    
    Update user roles to proper access physical infrastructure views
    (cherry picked from commit 12bfa5273a01bafe5caa6e3d810b0c2ddf1cdeea)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530680
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530681
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1530683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants