Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the type name for the catalog Item from 'Container Template' to 'Openshift Template' #16639

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Change the type name for the catalog Item from 'Container Template' to 'Openshift Template' #16639

merged 1 commit into from
Dec 11, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Dec 11, 2017

Change the type name for the catalog Item from 'Container Template' to 'Openshift Template'

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1518987

screenshot from 2017-12-11 15-28-17

@lgalis
Copy link
Contributor Author

lgalis commented Dec 11, 2017

@miq-bot add_label bug, gaprindashvili/yes

@lgalis
Copy link
Contributor Author

lgalis commented Dec 11, 2017

@mkanoor - please review

@miq-bot
Copy link
Member

miq-bot commented Dec 11, 2017

Checked commit lgalis@a4762cf with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@Loicavenel
Copy link

@lgalis Perfect

@lgalis lgalis changed the title [WIP]Change the type name for the catalog Item from 'Container Template' to 'Openshift Template' Change the type name for the catalog Item from 'Container Template' to 'Openshift Template' Dec 11, 2017
@miq-bot miq-bot removed the wip label Dec 11, 2017
@dclarizio dclarizio self-assigned this Dec 11, 2017
@dclarizio dclarizio merged commit 55cde62 into ManageIQ:master Dec 11, 2017
@dclarizio dclarizio added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 11, 2017
simaishi pushed a commit that referenced this pull request Dec 12, 2017
@simaishi
Merge pull request #16639 from lgalis/fix_openshift_catalog_type_name
17d962a 
Change the type name for the catalog Item from 'Container Template' to 'Openshift Template'
(cherry picked from commit 55cde62)

https://bugzilla.redhat.com/show_bug.cgi?id=1525043
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 17d962a1701db489188c15ffa02a2acf27560216
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Mon Dec 11 14:51:43 2017 -0800

    Merge pull request #16639 from lgalis/fix_openshift_catalog_type_name
    
    Change the type name for the catalog Item from 'Container Template' to 'Openshift Template'
    (cherry picked from commit 55cde62ef862129152086b7e96923987129025db)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1525043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
bug gaprindashvili/backported lifecycle/services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lgalis @miq-bot @Loicavenel @simaishi @dclarizio